search

nodejs / string_decoder

'string_decoder' module from Node.js core
Other
32 stars 20 forks source link

Setup CI environment #5

Open mcollina opened 7 years ago

mcollina commented 7 years ago

We would to run this on multiple Node.js environments, from 0.8 to 8.

cc @nodejs/build

mcollina commented 6 years ago

@nodejs/build I just need someone to set up the webhook for Travis I don't have access to the secrets.

rvagg commented 6 years ago

@joyeecheung I think you did the most recent travis integration, can you give us some hints? I can't do this off the top of my head.

phillipj commented 6 years ago

Linking with https://github.com/nodejs/github-bot/issues/166 for future ref.

mcollina commented 6 years ago

The bot is configured properly, but Travis is not picking it up.

mcollina commented 6 years ago

Alternatively, can someone from @nodejs/build set up a CI environement identical to the one of readable-stream?

rvagg commented 6 years ago

https://ci.nodejs.org/job/string_decoder-continuous-integration/ is this OK? You'll need a ci script of course.

mcollina commented 6 years ago

@rvagg seems something is not working as expected, https://ci.nodejs.org/job/string_decoder-continuous-integration/MACHINE=debian8-64/3/ is picking up all versions not just one

gibfahn commented 6 years ago

@rvagg seems something is not working as expected, ci.nodejs.org/job/string_decoder-continuous-integration/MACHINE=debian8-64/3 is picking up all versions not just one

The way I've ended up doing it previously is having a pipeline that triggers the continuous-integration job for each NODE_VERSION.

gibfahn commented 6 years ago

Which is what was done for readable-stream it seems.

@mcollina does this work? https://ci.nodejs.org/view/All/job/string_decoder-pipeline/

mcollina commented 6 years ago

Yes, my code is broken :D.

rvagg commented 6 years ago

broken on v0.10 and v0.12, are we still supporting those with readable-stream and friends?

mcollina commented 6 years ago

Yes, the code should work, I need fo finish the regexps porting from readable-stream.