Move logic to interceptors

nodejs / undici

An HTTP/1.1 client, written from scratch for Node.js

https://nodejs.github.io/undici

MIT License

6.29k stars 551 forks source link

Move logic to interceptors #2943

Open ronag opened 8 months ago

ronag commented 8 months ago

Once https://github.com/nodejs/undici/pull/2826 lands we can start moving some logic into interceptors in order to ensure we get similar logic for all api implementations:

[ ] throwOnError as interceptor
[ ] dump as interceptor
[ ] signal handling as interceptor

metcoder95 commented 8 months ago

Shall we mark them as good-first-issue? I believe that at least two of them (signaling and throwOnError) can be done easily

ronag commented 8 months ago

I don't think this needs to be semver major.

stu01509 commented 8 months ago

Hi @ronag

I'm interested in this topic, can I pick this?

mcollina commented 8 months ago

go for it!