search

nodejs / undici

An HTTP/1.1 client, written from scratch for Node.js
https://nodejs.github.io/undici
MIT License
5.99k stars 524 forks source link

interceptors: move `throwOnError` to interceptor #3275

Open metcoder95 opened 3 months ago

mcollina commented 3 months ago

I'm not sure we can, but it would be cool to do

ronag commented 3 months ago

Done here: https://github.com/nxtedition/nxt-undici/blob/main/lib/interceptor/response-error.js if someone wants to port it.

metcoder95 commented 1 month ago

Closed by #3331

ronag commented 1 month ago

We are still not actually using the interceptor

metcoder95 commented 1 month ago

True 🤦‍♂️ Too preemptive

metcoder95 commented 1 week ago

Safe to close now with #3451? 😜