nodejs / undici

An HTTP/1.1 client, written from scratch for Node.js
https://nodejs.github.io/undici
MIT License
6.08k stars 529 forks source link

fetch: fix content-encoding order #3343

Closed tsctx closed 3 months ago

tsctx commented 3 months ago

When decoding, it must be processed from the reverse. We didn't catch this because the test is wrong.

KhafraDev commented 3 months ago

At some point c415fbbb59e2b898c5db6a681265cf3da865d02c got reverted... why?

climba03003 commented 3 months ago

@KhafraDev FYI, see https://github.com/nodejs/undici/pull/2061 for the reason why it being reverted. This PR is implementing the correct order.

KhafraDev commented 3 months ago

It seems like I mentioned this in https://github.com/nodejs/undici/pull/2061/files#r1305403864 and then never followed up on.