search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
250 stars 53 forks source link

ignore failures building all recipes but fetch-source #10

Closed joaocgreis closed 5 years ago

joaocgreis commented 5 years ago

v12.11.0 was not published because of a failure building x86. Until that is fixed it is blocking other recipes and promotion of assets. This PR changes build.sh to keep building other recipes when one fails.

This was not tested, I will fix any issue if we agree this is the way to move forward.

cc @rvagg

richardlau commented 5 years ago

v12.11.0 was not published because of a failure building x86. Until that is fixed it is blocking other recipes and promotion of assets.

Unofficial builds of v12.11.0 failed because they build from the source tarball which is broken (https://github.com/nodejs/node/issues/29709). https://github.com/nodejs/node/pull/29712 fixed the source tarball generation but would need a new release.

That's not to say the idea here of not allowing one failing recipe to block the others isn't a good idea.

rvagg commented 5 years ago

yeah, what @richardlau said, I manually edited this file on the server and removed x86 and then musl failed, which is why nodejs/node#29709 turned from "x86 is broken" to "it's all broken". But you're right, this has been a TODO