search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
221 stars 46 forks source link

Debug build #112

Closed matthewkeil closed 5 months ago

matthewkeil commented 5 months ago

NOTE: Reopened PR #107. Please see that PR for comments and commit history

Hello and thank you for your consideration. I am part of the ChainSafe/lodestar team and we are heavy users of both node and native dependencies. We often have segfaults pop up on our CI through normal course of business and having Node.js built with Debug symbols makes life MUCH easier to debug issues.

We use the Github workflow action actions/setup-node and would like to add a "debug" option to that to have it pull and install a Debug build of node. We have built a fork that creates these releases for ourselves ChainSafe/node_debug but as active contributors to the open source community would like to offer this PR as an addition to the unofficial-builds repo so they everyone in the community can benefit from them as much as we do.

If the images can get built here we will PR our actions/setup-node action back to the main repo so that the binaries are still being served by the node organization instead of our repo. Not sure this is critical but thought it would be more "official" even though its hosted in the "unofficial-builds". A penny for your thoughts on that?

This is my first time contributing to this repo and think I have crossed all my t's and dotted all of my i's but would love some feedback to make sure that it meets standards.

Thanks for the opportunity to give back to the community!

@matthewkeil

matthewkeil commented 5 months ago

@rvagg what is the process for submitting versions for the build queue?

rvagg commented 5 months ago

@matthewkeil you mean for historical versions? We have a bit of an unresolved problem with that—the Docker build people rely on a stable hash digests for the builds and we can only rebuild all recipes at the moment. I've detailed the problem here: https://github.com/nodejs/unofficial-builds/issues/114

Right now the only option is to wait until the next Node.js release for this recipe to start producing binaries. Or do it manually, but that's a bit too involved and tedious.