nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
221 stars 46 forks source link

Update run.sh to exclude sys/random.h for this target #127

Closed scosol closed 3 months ago

scosol commented 3 months ago

nodejs sources were updated with some glibc 2.25+ functionality around expecting/detecting sys/random.h and getrandom() This target specifically is meant for lesser glibc versions, thus we specifically disable the new expectations

rvagg commented 3 months ago

@scosol this seems OK to me, but have you managed to try building this locally to confirm it works?

scosol commented 3 months ago

@scosol this seems OK to me, but have you managed to try building this locally to confirm it works?

I've just built successfully for: ./local_build.sh -r x64-glibc-217 -v v20.12.1 ./local_build.sh -r x64-glibc-217 -v v18.20.1

❯ ls -al ~/src/github/staging/release/v18.20.1 total 134592 drwxr-xr-x 4 scosol staff 128 Apr 3 10:59 . drwxr-xr-x 4 scosol staff 128 Apr 3 11:31 .. -rw-------@ 1 scosol staff 44713613 Apr 3 10:59 node-v18.20.1-linux-x64-glibc-217.tar.gz -rw-------@ 1 scosol staff 24193232 Apr 3 10:59 node-v18.20.1-linux-x64-glibc-217.tar.xz ❯ ls -al ~/src/github/staging/release/v20.12.1 total 142088 drwxr-xr-x 4 scosol staff 128 Apr 3 12:49 . drwxr-xr-x 4 scosol staff 128 Apr 3 11:31 .. -rw-------@ 1 scosol staff 46947672 Apr 3 12:48 node-v20.12.1-linux-x64-glibc-217.tar.gz -rw-------@ 1 scosol staff 25796820 Apr 3 12:49 node-v20.12.1-linux-x64-glibc-217.tar.xz ~/src/github/nodejs-unofficial-builds/bin  main 

rvagg commented 3 months ago

don't suppose you'd like to tackle some of the others while your head is in here?

scosol commented 3 months ago

don't suppose you'd like to tackle some of the others while your head is in here?

Sure- but I don't see any formal issues directly calling any other failures out? Shall I assume that anything not showing up here: https://unofficial-builds.nodejs.org/download/release/v20.12.1/ is currently "broken"?

scosol commented 3 months ago

don't suppose you'd like to tackle some of the others while your head is in here?

https://github.com/nodejs/unofficial-builds/pull/129