search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
221 stars 46 forks source link

fix: npm --exec #132

Closed rvagg closed 3 months ago

rvagg commented 3 months ago

From https://unofficial-builds.nodejs.org/logs/202404060314-v20.12.0/build.log

+ npm --exex -y nodejs-dist-indexer@v1.7.1 -- --dist /home/nodejs/download/release --indexjson /home/nodejs/download/release/index.json --indextab /home/nodejs/download/release/index.tab
Unknown command: "nodejs-dist-indexer@v1.7.1"
matthewkeil commented 3 months ago

I didn't (clearly) test that indexer command @rvagg, I just moved it up and addressed the PR comment (that introduced the typo) hopefully it goes smoothly because it was being run all at once and now runs one at a time. Just thought about that.

I assumed I would get another bite at the apple to fix things after review and then it kinda fell off my radar and I got busy with a few other things.

If there are future things I work on in here I'll make sure I'm more thorough before going to review

rvagg commented 3 months ago

this one might have been me tbh, s'ok