search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
247 stars 52 forks source link

local_build.sh logic is broken (may be affecting prod build as well) #137

Closed scosol closed 5 months ago

scosol commented 5 months ago

local_build.sh is expecting "[WORKDIR]../../var/build_queue" to exist and the script fails until:

mkdir ../../var touch ../../var/build_queue

Then the script succeeds

local_build.sh calls the same things used by the automated production build and I am worried that the current automated build is working off of the old(existing) build_queue instead of the new build_queue in the new location because of this. (causing none of the targets I fixed, to be built)

not sure what the reasoning was for refactoruing the location of things, but without access to the actual build server my level of assistance here is going to be limited

rvagg commented 5 months ago

don't suppose you could submit a PR to deal with this? it's a fairly new script and there was an attempt to share logic with the server build script which is why you're seeing this. it works on my machine because I have it set up like this so obviously haven't noticed.

scosol commented 5 months ago

https://github.com/nodejs/unofficial-builds/pull/140