search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
242 stars 50 forks source link

centos:7 builds are failing #147

Closed jwalton closed 1 month ago

jwalton commented 2 months ago

All the centos:7 builds appear to be failing, because of this.

rvagg commented 2 months ago

@jwalton we're just using centos:7 from Docker, would you mind trying to figure out whether this is just a matter of updating the base images? Or is there something we need to do to modify the images themselves once we have them running.

LaurentGoderre commented 2 months ago

I think the image should switch to a different base OS because CentOS is EOL and won't get any security updates anymore

jwalton commented 2 months ago

I'm looking into fixes.

At least for x64-glibc-217, I doubt there's a more recent image we can switch to, as newer images will all be based on a more recent glibc.

jwalton commented 2 months ago

Alright,https://github.com/nodejs/unofficial-builds/pull/149 should fix it. Tried this out with x64-glibc-217 and made sure it built successfully. I also tried x64-pointer-compression and stopped it before it completed, but made sure it got into the compilation phase (it won't get anywhere near that far without the fix).

rvagg commented 1 month ago

With fixes merged, are there specific missing builds people want retried that we can queue to test this? Otherwise it'll wait until the next nightly or release.