search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
242 stars 50 forks source link

Node 16 Apline builds #28

Closed nschonni closed 3 years ago

nschonni commented 3 years ago

Might just be a bit backed up, but there where a few files dropped in https://unofficial-builds.nodejs.org/download/release/v16.0.0/ awhile ago, but not the musl binaries. Not sure if it's related to the recent release machine issue, or if the CI is just chugging along and it's a patience thing.

rvagg commented 3 years ago

Yep, it's borked, python3 is missing. See logs for each build @ https://unofficial-builds.nodejs.org/logs/202104201637-v16.0.0/

Someone's going to have to go through all the Dockerfiles in https://github.com/nodejs/unofficial-builds/tree/master/recipes and get python3 into them. I'll get around to it sometime if nobody else does but have too much else on my plate right now.

nschonni commented 3 years ago

Right, it looks like we did it this way for the docker-node setup https://github.com/nodejs/docker-node/pull/1331/files, but that's generating the Dockerfiles before they get built

Smirl commented 3 years ago

This is causing pre-commit to fail for me.

Specifically because of the missing binaries here: https://unofficial-builds.nodejs.org/download/release/v16.0.0/

Compared to here: https://unofficial-builds.nodejs.org/download/release/v15.9.0/

rvagg commented 3 years ago

16.0.0 builds are out, get em while they're fresh 🍰