search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
242 stars 50 forks source link

fixup armv6l recipes #34

Closed richardlau closed 3 years ago

richardlau commented 3 years ago

Add the renamed armv6l-pre16 recipe to the explicit recipe list to build.

Add missing dependency (python3-distutils) for the new armv6l recipe to fix 

ModuleNotFoundError: No module named 'distutils.spawn'

error. FWIW in https://github.com/nodejs/build/blob/master/ansible/roles/docker/templates/ubuntu1804_arm_cross.Dockerfile.j2 python3-distutils is installed as a dependency of python3-pip -- we do not need to install pip on the unofficial build Docker image as we're not running tap2junit here.

Refs: https://github.com/nodejs/unofficial-builds/pull/33

richardlau commented 3 years ago

mea culpa for some reason I thought the scripts would just enumerate over the directories in recipes (like we do for building images https://github.com/nodejs/unofficial-builds/blob/0d49da59de10fa5edbcff47093194a44dfacd85c/bin/prepare-images.sh#L8-L10) but there's an explicit list in https://github.com/nodejs/unofficial-builds/blob/0d49da59de10fa5edbcff47093194a44dfacd85c/bin/build.sh#L11-L17.

FWIW The next release pre16 we have planned is next Tuesday (14.17.0, delayed for a week https://github.com/nodejs/node/pull/38507#issuecomment-831514785).