search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
250 stars 53 forks source link

chore: Use openpgp/ubuntu keyservers #39

Closed nschonni closed 3 years ago

nschonni commented 3 years ago

SKS no longer publishes DNS. Same approach from docker-node Fixes https://github.com/nodejs/unofficial-builds/issues/37

nschonni commented 3 years ago

@richardlau thanks! Do the security release builds need to be manually re-triggered to re-run?

richardlau commented 3 years ago

@nschonni I manually requeued them.

FYI the release team is planning releases today to fix a Windows installer regression in the security releases. Hopefully the process should just work with this PR merged and the unofficial builds occur automatically.

nschonni commented 3 years ago

I wonder if the images need to be pushed out somehow. It looks like the new 12.22.2 still hit the old keyserver https://unofficial-builds.nodejs.org/logs/202107011554-v12.22.2/fetch-source.log

nschonni commented 3 years ago

Actually 12.22.3 seems OK now https://unofficial-builds.nodejs.org/logs/202107051602-v12.22.3/

richardlau commented 3 years ago

I wonder if the images need to be pushed out somehow. It looks like the new 12.22.2 still hit the old keyserver https://unofficial-builds.nodejs.org/logs/202107011554-v12.22.2/fetch-source.log

🤦 I probably queued the builds too early and needed to wait for the images to rebuild (it's automatic on repository pushes). I'll queue them up again.

nschonni commented 3 years ago

No worries. Looks like 12.22.3 completed successfully, but maybe the others are still in the queue

richardlau commented 3 years ago

14.17.3 is in progress: https://unofficial-builds.nodejs.org/logs/202107051715-v14.17.3/

I did queue 16.4.1, 14.17.2 and 12.22.2 again -- I saw them queued and now they're not but I can't find any evidence they were rerun 😕.

richardlau commented 3 years ago

14.17.3 is in progress: https://unofficial-builds.nodejs.org/logs/202107051715-v14.17.3/

I did queue 16.4.1, 14.17.2 and 12.22.2 again -- I saw them queued and now they're not but I can't find any evidence they were rerun 😕.

Found the logs (journalctl -u nodejs-periodic.service):

Jul 05 15:12:43 infra-digitalocean-ubuntu1804-x64-2 periodic.sh[1518]: Unknown version: 16.4.1
Jul 05 15:17:44 infra-digitalocean-ubuntu1804-x64-2 periodic.sh[1605]: Unknown version: 14.17.2
Jul 05 15:22:50 infra-digitalocean-ubuntu1804-x64-2 periodic.sh[2167]: Unknown version: 12.22.2

Apparently I fail at reading 🤦: https://github.com/nodejs/unofficial-builds/blob/master/README.md#manual-build-triggers

the "v" is necessary

rvagg commented 3 years ago

cool, thanks for fixing, but the indenting .. 🤦