search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
227 stars 47 forks source link

Add recipe definition for building on riscv64 #54

Closed sxa closed 2 years ago

sxa commented 2 years ago

Configuration to allow building for RISC-V as an unofficial build platform.

Since this is my first contribution to here and I don't have access to the box used for cross-compilation I cannot verify for certain that it will work properly, but the setup seems adequate for building the latest versions for RISC-V.

(If run.sh isn't the right place to add the configure arguments, let me know)

Should e enough to satisfy the requirements to move RISC-V to experimental

Signed-off-by: Stewart X Addison sxa@redhat.com

rvagg commented 2 years ago

Well, since you've put in the effort and are already in the trust-circle, I'm going to add you to the machine! But you have two keys in GitHub, which key do you want me to put in for you? Then you can have a play to see if you can make it work live, I acknowledge that it's very difficult to actually test these things without the full setup.

sxa commented 2 years ago

Thanks - I use both but the main one that I have on most other machines is the one ending in VOSt - thanks!

richardlau commented 2 years ago

Well, since you've put in the effort and are already in the trust-circle, I'm going to add you to the machine! But you have two keys in GitHub, which key do you want me to put in for you? Then you can have a play to see if you can make it work live, I acknowledge that it's very difficult to actually test these things without the full setup.

FTR I've added @sxa 's key to the machine (it wasn't there).

sxa commented 2 years ago

Machine is low on disk space so I cannot progress this. Raised at https://github.com/nodejs/unofficial-builds/issues/55

sxa commented 2 years ago

Other than the fact this is overriding the --with-intl=none this is now working correctly (I suspect I'd need to unset BUILD_INTL_FLAGS in the top level Makefile to work around it. While it builds with full-intl it was causing problems (hangs IIRC) during the test suite, so it's not ideal to have it enabled at the moment, but we can iterate on that as the development moves on :-)

I've adjusted the riscv64 ccache directory on the machine to be limited to 1G for now to avoid it chewing up even more space ref: #55

This should now be good to go although I'll avoid merging until tomorrow as I'd prefer not to deploy to production while it's my evening :-) (I'm assuming that landing this will cause the docker image to be rebuilt as I've cleared off the one I'd created on the machine for testing). I've completed a run of 17.7.1 and 17.9.0.