search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
227 stars 47 forks source link

Fix x86 recipe (skip OpenSSL asm code) #63

Closed ochafik closed 6 months ago

rvagg commented 1 year ago

thanks, I wasn't aware this is failing, can you point to logs for this failure?

ashthespy commented 1 year ago

Looks like it's been failing for a while? v18.5.0

  CC(target) /home/node/node-v18.10.0/out/Release/obj.target/openssl/deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.o
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S: Assembler messages:
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:5: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:8: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:277: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:280: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:439: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:442: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:998: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1001: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1066: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1069: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1426: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1429: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1647: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:1650: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2210: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2213: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2280: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2283: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2816: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:2819: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3053: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3056: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3066: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.S:3069: Error: junk at end of line, first unrecognized character is `%'
make[2]: *** [deps/openssl/openssl.target.mk:1157: /home/node/node-v18.10.0/out/Release/obj.target/openssl/deps/openssl/config/archs/linux-elf/asm/crypto/aes/aes-586.o] Error 1
make[2]: *** Waiting for unfinished jobs....
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S: Assembler messages:
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:7: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:10: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:39: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:42: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:69: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:72: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:101: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:104: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:133: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:136: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:170: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:173: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:207: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:210: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:250: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:253: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:293: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:296: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:352: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:355: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:413: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:416: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:653: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:656: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:746: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:749: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:874: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:877: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:1117: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:1120: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:1482: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:1485: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:1877: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:1880: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:2277: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:2280: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:2677: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:2680: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:2941: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:2944: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:3281: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:3284: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:3297: Error: junk at end of line, first unrecognized character is `%'
../deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.S:3300: Error: junk at end of line, first unrecognized character is `%'
make[2]: *** [deps/openssl/openssl.target.mk:1157: /home/node/node-v18.10.0/out/Release/obj.target/openssl/deps/openssl/config/archs/linux-elf/asm/crypto/aes/aesni-x86.o] Error 1
make[1]: *** [Makefile:113: node] Error 2
make: *** [Makefile:1239: node-v18.10.0-linux-x86.tar] Error 2
rvagg commented 1 year ago

fair enough, is it breaking across all versions, or can we version limit this?

ashthespy commented 1 year ago

Not sure what versions you mean, but it's broken from 18.5.0 --> 19.7.0.

mleppanen commented 6 months ago

Are there plans to integrate this or why it is still open? There has not been an x86 version for a while now.

rvagg commented 6 months ago

thanks for the ping