nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
227 stars 47 forks source link

14.21.1 security release build stalled #65

Closed nschonni closed 1 year ago

nschonni commented 1 year ago

Looks like the fetch source job failed https://unofficial-builds.nodejs.org/logs/202211042053-v14.21.1/fetch-source.log

+ curl -fsSLO --compressed https://nodejs.org/download/release/v14.21.1/node-v14.21.1.tar.xz
+ [[ release = \r\e\l\e\a\s\e ]]
+ curl -fsSLO --compressed https://nodejs.org/download/release/v14.21.1/node-v14.21.1.tar.xz/../SHASUMS256.txt.asc
curl: (22) The requested URL returned error: 500

That in turn is blocking the docker-node auto-pr for the other release lines

nschonni commented 1 year ago

@richardlau @rvagg not sure if someone can trigger this build again

nschonni commented 1 year ago

@sxa do you have access to reque this? This is blocking the rollout of the security releases for Docker

nschonni commented 1 year ago

@nodejs/build anyone else has access to requeue the job

sxa commented 1 year ago

I was on vacation yesterday so didn't see it - I'll take a look at it now. I wasn't aware the unofficial builds were used by our docker workflows.

targos commented 1 year ago

It's a bit concerning that the Docker releases rely on unofficial builds.

sxa commented 1 year ago

Queued and running now. @nschonni Which of the unofficial builds are mandatory for (thus blocking) the docker releases? I see the musl ones referenced in the linked issue but is that the only one?

nschonni commented 1 year ago

The musl one is the only one used by Docker

nschonni commented 1 year ago

Build succeeded and the automation is working again. Thanks!

sxa commented 1 year ago

Closing, although we should consider the implications of the dependencies of the unofficial builds process in light of this.

rvagg commented 1 year ago

Perhaps we need to give @nschonni or someone else on the docker-node WG access to the machine to trigger rebuilds?