search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
227 stars 47 forks source link

Fix Riscv recipe #79

Closed rvagg closed 1 year ago

rvagg commented 1 year ago

From https://github.com/nodejs/unofficial-builds/issues/78#issuecomment-1533957059

It needs to be either fixed or removed from here. Any pushes to the main branch here will result in a broken deploy and therefore non-update of the server's copy of this repo until this is addressed.

sxa commented 1 year ago

Thanks for disabling it for now (I've been on vacation for the last two weeks) - it's a redirect issue as a result of a name change - switching it to ci.adoptium.net instead of ci.adoptopenjdk.net will fix it although there's another issue around with an alternate option for this so I'll hold off on implementing that for a few days.

sxa commented 1 year ago

FYI I've rebuilt and it's up including RISC_V at https://unofficial-builds.nodejs.org/download/release/v20.2.0/

rvagg commented 1 year ago

uh, probably shouldn't have rebuilt, it causes problems for the docker-node folks to have a changed SHASUMs; something we ought to put in the README, or figure out with them

sxa commented 1 year ago

I have backups - I'll restore all but riscv64 ... Noted for future

sxa commented 1 year ago

Of course, if we manage to get fully reproducible builds working that wouldn't be a problem ;-)