search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
227 stars 47 forks source link

Remove custom yum repo in favor for centos-release-scl-rh #85

Closed watson closed 1 year ago

watson commented 1 year ago

This PR should make the x64-glibc-217 recipe a little simpler by removing the custom yum repo used to install devtoolset-9. Instead we can get devtoolset-9 from installing centos-release-scl-rh.

I've also added a ulimit -n 1024 before running yum because of this known issue on centos 7: https://stackoverflow.com/questions/74345206/centos-7-docker-yum-installation-gets-stuck

I haven't personally run into this bug on centos 7, but it seems to be a good idea to add it to make the install more stable.

richardlau commented 1 year ago

this seems fine to me, @richardlau @sxa either of you want to weigh in on whether this is a good idea or not?

I don't know because I don't really have any insight on how the Cloudlinux repository is managed as a comparison.

What we do know is that in the past devtoolset-6 vanished completely from the Software Collections repository https://forums.centos.org/viewtopic.php?t=71663

Red Hat considers devtoolset-9 retired as of December 2021: https://access.redhat.com/support/policy/updates/rhscl-rhel7 Although AFAICT devtoolset-7 and later are all still available on Software Collections.

rvagg commented 1 year ago

I guess we'll find out then!