search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
227 stars 47 forks source link

v20.4.0 build failed #87

Closed tim-richter closed 1 year ago

tim-richter commented 1 year ago

Hi :wave: Latest release is currently empty (https://unofficial-builds.nodejs.org/download/release/v20.4.0/), because the build failed in fetch-source https://unofficial-builds.nodejs.org/logs/202307051402-v20.4.0/fetch-source.log.

Something similar also happened in https://github.com/nodejs/unofficial-builds/issues/86. Not sure exactly what the issue here is.

rvagg commented 1 year ago

Well that's pretty annoying. Happening twice makes it a pattern. This should be hitting Cloudflare, but there's a small chance that we're the first client to download that file when it's newly promoted so maybe there's a cache issue here. :shrug: I'll requeue it.

tim-richter commented 1 year ago

Maybe adding a retry for that particular curl request would already suffice? I'm not that familiar with this project, but I could try adding that to fetch-source

rvagg commented 1 year ago

yep, that might be a good thing to do, loop a few times with a sleep between

tim-richter commented 1 year ago

Opened a PR for this #88. The 20.4 build was successful tho, so I will close this issue. Thanks @rvagg!