This adds a recipe that downloads a copy of the headers to be included in the Unofficial Builds releases and changes the RELEASE_URLBASE to point to that copy.
The node-gyp changes in https://github.com/nodejs/node-gyp/pull/1875 require this. Windows ARM64 releases need to download node.lib from this server. Changing node-gyp to get node.lib from here and the headers from the main server doesn't make much sense to me. This approach makes it more consistent, at the expense of having to duplicate the headers files.
@rvagg can you take a look? I haven't tested this. I plan to land this, let docker update and then fix anything that needs fixing. But I can test the changes in the server and update this PR if you prefer. In any case, I'll run the new recipe for v12.8.0 which I'm using to test the node-gyp side.
rvagg
commented
4 years ago
This adds a recipe that downloads a copy of the headers to be included in the Unofficial Builds releases and changes the RELEASE_URLBASE to point to that copy.
The node-gyp changes in https://github.com/nodejs/node-gyp/pull/1875 require this. Windows ARM64 releases need to download
node.libfrom this server. Changing node-gyp to getnode.libfrom here and the headers from the main server doesn't make much sense to me. This approach makes it more consistent, at the expense of having to duplicate the headers files.@rvagg can you take a look? I haven't tested this. I plan to land this, let docker update and then fix anything that needs fixing. But I can test the changes in the server and update this PR if you prefer. In any case, I'll run the new recipe for v12.8.0 which I'm using to test the node-gyp side.