search

nodejs / unofficial-builds

Unofficial binaries for Node.js
https://unofficial-builds.nodejs.org
221 stars 46 forks source link

Loong64 and riscv are missing from the index #97

Closed wangling12 closed 10 months ago

wangling12 commented 10 months ago

At least there are riscv and loong64 tars in https://unofficial-builds.nodejs.org/download/release/v20.6.0/

But it seems that these architectures are missing in ndex.json and index.tab.

rvagg commented 10 months ago

oh, good catch; we probably need to update https://github.com/nodejs/nodejs-dist-indexer/blob/main/transform-filename.js#L37-L42

would you mind opening a pull request to add the missing ones there? we also might need something on the README here to remind people when adding new types

wangling12 commented 10 months ago

Finished, hope there are nothing wrong in prs.

rvagg commented 10 months ago

old:

{"version":"v20.6.1","date":"2023-09-08","files":["headers","linux-armv6l","linux-x64-musl","linux-x64-pointer-compression"],"npm":"9.8.1","v8":"11.3.244.8","uv":"1.46.0","zlib":"1.2.13.1-motley","openssl":"3.0.10+quic","modules":"115","lts":false,"security":false},

new:

{"version":"v20.6.1","date":"2023-09-08","files":["headers","linux-armv6l","linux-loong64","linux-riscv64","linux-x64-glibc-217","linux-x64-musl","linux-x64-pointer-compression"],"npm":"9.8.1","v8":"11.3.244.8","uv":"1.46.0","zlib":"1.2.13.1-motley","openssl":"3.0.10+quic","modules":"115","lts":false,"security":false},

thanks for the contribution!