search

nodejs / user-feedback

Node.js User Feedback Initiative
https://github.com/nodejs/user-feedback
56 stars 18 forks source link

2018-02-16 Public meeting notes #33

Closed ghost closed 6 years ago

ghost commented 6 years ago

Created 2018-02-16 Public meeting notes.md

ghost commented 6 years ago

To close this PR, I want to make sure nothing bad will happen. Not sure how these old commits that are no longer necessary face up, the only modified file should be 2018-02-16-Public-meeting.md . Is it safe to merge this PR? Or do I need to git rebase(I need to take a look on help documentation)? Thanks

dshaw commented 6 years ago

@mihaiep I'm not sure how to do that on the web interface. If you want to redo the PR, that's fine too. It might be easier.

ghost commented 6 years ago

usually I'm using Git Bash on my local directory and then using git commands to sync.

dshaw commented 6 years ago

Rebasing should work then.

ghost commented 6 years ago

I think I need to delete all history (14 old commits) excluding 2018-02-16 Public User Feedback Meeting- ce81ec4. How should I do this?

dshaw commented 6 years ago

I would use git reset. https://www.atlassian.com/git/tutorials/resetting-checking-out-and-reverting

ghost commented 6 years ago

I opened this https://github.com/nodejs/user-feedback/pull/40 to fix old commits