search

nodejs / uvwasi

WASI syscall API built atop libuv
MIT License
226 stars 50 forks source link

test: remove unused variables #134

Closed danbev closed 4 years ago

danbev commented 4 years ago

When enabling all warnings the unused variables are reported:

$ cmake .. -DCMAKE_C_FLAGS=-Wall
gengjiawen commented 4 years ago

Any thought on put this flags in CMakeList.txt ?

danbev commented 4 years ago

Any thought on put this flags in CMakeList.txt ?

I think that would be good if it could be added :+1:

sbc100 commented 4 years ago

At the very least we should add these flags in CI... but that doesn't' need to block this PR either.

danbev commented 4 years ago

are you interested in updating the CI too?

Sure thing, I'll try to take a look at this later today or early next week.

Landed in 1db9b7202885aa0fcae4b88a3699cd29e7370759.