search

nodejs / uvwasi

WASI syscall API built atop libuv
MIT License
226 stars 50 forks source link

Android build warnings #137

Closed gengjiawen closed 4 years ago

gengjiawen commented 4 years ago

Aside from https://github.com/libuv/libuv/pull/2857

/__w/uvwasi/uvwasi/src/uvwasi.c:1214:5: warning: implicit declaration of function 'seekdir' [-Wimplicit-function-declaration]
    seekdir(dir->dir, cookie);
    ^
/__w/uvwasi/uvwasi/src/uvwasi.c:1214:5: warning: this function declaration is not a prototype [-Wstrict-prototypes]
/__w/uvwasi/uvwasi/src/uvwasi.c:1233:14: warning: implicit declaration of function 'telldir' [-Wimplicit-function-declaration]
      tell = telldir(dir->dir);
             ^
/__w/uvwasi/uvwasi/src/uvwasi.c:1233:14: warning: this function declaration is not a prototype [-Wstrict-prototypes]
cjihrig commented 4 years ago

https://github.com/cjihrig/uvwasi/pull/144 should resolve the warnings from libuv.

The remaining warnings are from uvwasi_fd_readdir(). That function needs work. I might disable it on Android and Windows until the WASI API changes (🤞) or a better implementation is written here.