search

nodejs / uvwasi

WASI syscall API built atop libuv
MIT License
226 stars 50 forks source link

build: add -Wall -Werror to CI build #138

Closed danbev closed 4 years ago

danbev commented 4 years ago

This commit adds build flags to CMake to enable all warnings and to turn warnings into errors.

danbev commented 4 years ago

@cjihrig Would something like this be enough for CI (minus the last commit which is just to show that it fails upon a warnings).

cjihrig commented 4 years ago

I think so. It would be good to do something similar on Windows at some point, since it has the most platform specific code.

cjihrig commented 4 years ago

@danbev are you still planning to work on this?

danbev commented 4 years ago

I’m on PTO at the moment and won’t be back for another 3 weeks.

But I still don’t have a windows env to try getting the same thing working on windows.

Perhaps this PR could be merged without that as it would at least fail on warnings for Unix environments? If not feel free to close this and I might revisit I when I get back.

lör 25 juli 2020 kl. 17:06 skrev Colin Ihrig notifications@github.com:

@danbev https://github.com/danbev are you still planning to work on this?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/cjihrig/uvwasi/pull/138#issuecomment-663865750, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADJRX4IOEE2VZ54F3LVPMTR5LYIZANCNFSM4NHOTH7Q .

cjihrig commented 4 years ago

I think this can land without Windows support. Can you take it out of draft status and get the CI passing (I think you just have an extra test commit)?