search

nodejs / uvwasi

WASI syscall API built atop libuv
MIT License
225 stars 49 forks source link

add stub for sock_accept #185

Closed mhdawson closed 1 year ago

mhdawson commented 1 year ago

add the stub for sock_accept so that we have stubs for all method in the current version of snapshot 1. sock_accept was added later after snapshot 1 was first documented.

Signed-off-by: Michael Dawson mdawson@devrus.com

mhdawson commented 1 year ago

Sorry pushed the button a bit early, moved to draft until I build as per uvwasi instructions instead of as dep of Node.js

mhdawson commented 1 year ago

@cjihrig is there anything I should do to help get this landed? I could push the button, but not sure I should do that even though you've approved?

cjihrig commented 1 year ago

@mhdawson feel free to merge. I'll open an issue for the Android build failure.

cjihrig commented 1 year ago

FYI - you should be able to get a green CI run after https://github.com/nodejs/uvwasi/pull/189 lands.

mhdawson commented 1 year ago

Rebased to pull in https://github.com/nodejs/uvwasi/pull/189

mhdawson commented 1 year ago

@cjihrig is it normal for the windows CI to take so long? I see the one after the android fix landed has been running for over 5 hours?

cjihrig commented 1 year ago

It's not normal. I restarted the CI one more time and everything is green now.

mhdawson commented 1 year ago

@cjihrig thanks, landing.