Node.js uvwasi team Meeting 2023-06-21

[mhdawson]

Time

UTC Wed 21-Jun-2023 18:00 (06:00 PM):

Timezone	Date/Time
US / Pacific	Wed 21-Jun-2023 11:00 (11:00 AM)
US / Mountain	Wed 21-Jun-2023 12:00 (12:00 PM)
US / Central	Wed 21-Jun-2023 13:00 (01:00 PM)
US / Eastern	Wed 21-Jun-2023 14:00 (02:00 PM)
EU / Western	Wed 21-Jun-2023 19:00 (07:00 PM)
EU / Central	Wed 21-Jun-2023 20:00 (08:00 PM)
EU / Eastern	Wed 21-Jun-2023 21:00 (09:00 PM)
Moscow	Wed 21-Jun-2023 21:00 (09:00 PM)
Chennai	Wed 21-Jun-2023 23:30 (11:30 PM)
Hangzhou	Thu 22-Jun-2023 02:00 (02:00 AM)
Tokyo	Thu 22-Jun-2023 03:00 (03:00 AM)
Sydney	Thu 22-Jun-2023 04:00 (04:00 AM)

Or in your local time:

• https://www.timeanddate.com/worldclock/fixedtime.html?msg=Node.js+Foundation+uvwasi%20team+Meeting+2023-06-21&iso=20230621T1800
• or https://www.wolframalpha.com/input/?i=06PM+UTC%2C+Jun+21%2C+2023+in+local+time

Links

• Minutes Google Doc: https://docs.google.com/document/d/1-nzEcZqc-dWskQGeOw6JOWIBRid01bCUKf62gQi2z3E/edit

Agenda

Extracted from uvwasi-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

nodejs/node

• WASI preview 1: fd_readdir ignores cookie argument #47193

nodejs/uvwasi

• feat!: Allow project to be installable #210
• What's new with uvwasi in 2023 #201
• Implement 4 stubbed out socket methods #200
• Changes to WASI spec in snapshot_preview2 #59

Invited

• uvwasi team: @nodejs/wasi

Observers/Guests

Notes

The agenda comes from issues labelled with uvwasi-agenda across all of the repositories in the nodejs org. Please label any additional issues that should be on the agenda before the meeting starts.

Joining the meeting

• link for participants: https://zoom.us/j/91612484369
• For those who just want to watch:
• youtube admin page: https://www.youtube.com/my_live_events?filter=scheduled

[mhdawson]

Minutes from the meeting today:

Node.js uvwasi team Meeting 2023-06-21

Links

• Recording: https://www.youtube.com/watch?v=C8x1VZikVmo
• GitHub Issue: https://github.com/nodejs/TSC/issues/1404

Present

• Michael Dawson (@mhdawson)
• Guy Bedford (@guybedford)
• Oscar Spencer (@ospencer)
• Blaine Bublitz (@phated)

Agenda

Announcements

*Extracted from uvwasi-agenda labelled issues and pull requests from the nodejs org prior to the meeting.

• No news this week.

nodejs/node

• WASI preview 1: fd_readdir ignores cookie argument #47193
  • No updates

nodejs/uvwasi

• feat!: Allow project to be installable #210
  • PR is up and Colin already approved - https://github.com/nodejs/uvwasi/pull/210
• What's new with uvwasi in 2023 #201
  • No news this week
• Implement 4 stubbed out socket methods #200
  • Oscar and Michael met to discuss some issues
  • Tricky issue is related to streams is that it really wants you to run a callback, but challenge in uvwasi.
  • To start will not worry about support non socket methods in v1, will add that in a follow on
  • Michael plans to start looking at adding some tests to the PR
• Changes to WASI spec in snapshot_preview2 #59
  • Guy
  • have got filesystem APIs working in fileshim
  • next big one is sockets
  • could start prototyping some of the areas, Guy still has some PoC implementations he could share
    • https://github.com/bytecodealliance/jco/tree/main/packages/preview2-shim
    • clocks, logging, random are pretty straight forward
    • io and fs are then on the next level
    • there could be interesting implementation feedback on these

Q&A, Other

Upcoming Meetings

• Node.js Project Calendar: https://nodejs.org/calendar

Click +GoogleCalendar at the bottom right to add to your own Google calendar.

[cjihrig]

Tricky issue is related to streams is that it really wants you to run a callback, but challenge in uvwasi.

Is the problem that the WASI APIs are blocking? Just off the top of my head, you may be able to create a uv_loop_t only for WASI to use. Then, you could call uv_run() to spin that event loop until the operation completes. You would still need to use callbacks, but from the caller's perspective things would seem to be blocking.

Of course, another option is to use native sockets directly. That would be a bigger pain up front, but probably lower overhead once all the wrinkles were ironed out.

[cjihrig]

cc: @mhdawson in case ^ is relevant to #214

[mhdawson]

@cjihrig thanks for the ping, once the listen takes place, is ok to defer a uv_run() until sock_accept is called? If so then following your suggestion the sock_accept implementation might be able to simply call uv_run with the option to just run once followed by calling uv_accept and do this in a loop until uv_accept indicates that a connection has come in.

[mhdawson]

@ospencer ^ so you are aware of this discussion.

[cjihrig]

@mhdawson sorry for the delay - I was traveling. To answer your question, I'm not 100% sure, but I think so. What you're describing is how I envisioned things working.

[mhdawson]

@cjihrig seems to be working so far see - https://github.com/nodejs/uvwasi/pull/214. So far just the uvwasi_sock_accept is being run so not 100% sure getting a socket we can use but looking good so far.