ci: add github-actions ci lint, coverage and nightly

nodejs / webcrypto

This repository has been archived. The WebCrypto API has been implemented in recent versions of Node.js and does not require additional packages.

69 stars 20 forks source link

ci: add github-actions ci lint, coverage and nightly #19

Closed panva closed 4 years ago

panva commented 5 years ago

Adds Github Actions CI with the following jobs

lint
test matrix on all actions-available platforms + minimal and current node versions
test on nightly

example run

tniessen commented 5 years ago

Do we have any rules or guidelines regarding GitHub actions @nodejs/tsc?

Trott commented 5 years ago

Do we have any rules or guidelines regarding GitHub actions @nodejs/tsc?

I think @nodejs/build may be experimenting with them in places? AFAIK, there are no guidelines or rules. This seems OK to me, but perhaps superfluous because you already have Travis? Although maybe it does stuff Travis doesn't.

Anyway, I defer to others on this, but I don't have a problem with it.

cclauss commented 5 years ago

My sense is that GitHub Actions is more modern than Travis CI in many ways and more pleasant to work with but it remains in Beta until November so there is still quirkiness.

rvagg commented 5 years ago

no guidelines and not much experimentation (if any?) in the org. I'd encourage experimentation like this because it's bound to become standard over time in the org and the sooner we figure out best practices the better. +1

cclauss commented 5 years ago

Other Actions experiments:

nodejs/node#29474 (open)
nodejs/node#29193 (closed)
nodejs/node-gyp#1671 (closed)

rvagg commented 5 years ago

Very sorry @cclauss, thanks for the correction

tniessen commented 4 years ago

Sorry @panva, I forgot about this. Would you mind updating the minimum Node.js version to match package.json so I can land this?

panva commented 4 years ago

@tniessen done, it'll take a merge to master to see the action run tho.