nodejs / webidl-napi

A WebIDL-to-N-API compiler
MIT License
10 stars 6 forks source link

all: make package a command line tool #2

Closed gabrielschulhof closed 4 years ago

gabrielschulhof commented 4 years ago

Signed-off-by: @gabrielschulhof

kainino0x commented 4 years ago

+1, I'd prefer to keep things moving fast in this project for now. Zero or one reviews would be fine for small things like this I think.

BTW, has there been an initial review of the code already in the repo?

gabrielschulhof commented 4 years ago

@kainino0x there has not been an initial review of the code.

gabrielschulhof commented 4 years ago

@austinEng @kainino0x the current policy coincides with the Node.js core PR policy. PTAL at https://github.com/nodejs/webidl-napi/issues/6 if you would like to speed things up.

gabrielschulhof commented 4 years ago

Landed in fa505afdd3491b226e665b82c6a37427f9822bad.