search

nodemailer / smtp-server

Create custom SMTP servers on the fly
Other
846 stars 145 forks source link

Still maintained? #211

Open SpeedyCraftah opened 5 days ago

SpeedyCraftah commented 5 days ago

Hello, I haven't seen much activity when it comes to this repository, and I know quite a lot of developers rely on it at the moment. I have some features I'd like to add including some bug fixes, but I'm not sure if my changes will be merged, and I want to avoid making a fork and adding those fixes and additions myself. What's the status of things at the moment?

One of the feature additions I had in mind at the moment is the ability to change the EHLO response in server options:

S: 250-XYZ.org Nice to meet you, mail-il1-f182.google.com

The server response to the EHLO is not standardised with the exception of the status, server domain, and incoming domain, and so I think it would be a nice touch to allow the customisation of that from "Nice to meet you", to something else, especially since the project allows the addition of a custom banner as it is.

endreszabo commented 4 days ago

well, it is in lib/smtp-connection.js, that you can easily edit. :)

SpeedyCraftah commented 4 days ago

well, it is in lib/smtp-connection.js, that you can easily edit. :)

Of course, but it's not that big of a feature to fork or modify the library and making any future updates very difficult to work with, just a nice thing to have, besides it wouldn't be the only thing I'd add or fix.