Provide a configuration option to disable reverse dns lookups

nodemailer / smtp-server

Create custom SMTP servers on the fly

Other

846 stars 146 forks source link

Provide a configuration option to disable reverse dns lookups #62

Closed furkanmustafa closed 7 years ago

andris9 commented 7 years ago

What is the use case here? If reverse resolving fails then the error is ignored so the current behavior should not be an issue?

furkanmustafa commented 7 years ago

When reverse resolving fails, it is working OK but adding too much delay to delivery depending on how it fails. For the internal network usage, that was a problem.

andris9 commented 7 years ago

fair enough, thanks

andris9 commented 7 years ago

Changed it a bit though. I don't really like default options that are true so I renamed the option to disableReverseLookup and the default for it is false. Published as v1.13.0

furkanmustafa commented 7 years ago

Thanks!