Closed titanism closed 3 months ago
Got it working!!!! 🎉
This PR is ready for merge, please review and merge, thank you! ✅
If you'd like to see the working implementation, see these files:
XAPPLEPUSHSERVICE
@ https://github.com/forwardemail/forwardemail.net/blob/master/helpers/imap/on-xapplepushservice.js which simply stores to database the user's APS data provided via this commandFeel free to try it out on https://forwardemail.net with your iOS device (setup an IMAP account)
PUSH now supported on iOS!!!! ⚡ (our alternative since IDLE not supported on iOS Mail)
OK it should be good to go now, I had one missing line of code (forgot to invoke this.send
) with APS version and sub topic.
https://github.com/titanism/wildduck/commit/6e006dbfe1463708fd8bca1f1f935b5f6b247023
PR ready.
Thanks for figuring this stuff out. I still need to edit it a bit; the commented-out code is not ideal; I will probably add a configuration option or smth.
Sounds good @andris9! Thank you 🙏
Added the following changes (https://github.com/nodemailer/wildduck/commit/4ef3eaabcad9fcacac5889cf8ad49d4e27233a60):
aps.enabled
option to be true, otherwise will reject the commandtag XAPPLEPUSHSERVICE
with no arguments caused an uncaught exception)
This adds command support for
XAPPLEPUSHSERVICE
with a commented out IMAP command handler showing an example implementation.