nodemcu / nodemcu-firmware

Lua based interactive firmware for ESP8266, ESP8285 and ESP32
https://nodemcu.readthedocs.io
MIT License
7.64k stars 3.12k forks source link

docs: update PULL_REQUEST_TEMPLATE.md #3452

Closed MichaelCurrin closed 2 years ago

MichaelCurrin commented 3 years ago

Note that there is no need to escape as #\<GitHub-issue-number\> if you use underscores instead of dashes.

e.g.

Fixes #<GITHUB_ISSUE_NUMBER>.

Fixes #.


Though, \<Description of and rationale behind this PR\> needs escaping or it will disappear. I made it italics instead.

nwf commented 2 years ago

Seems OK by me; can we preview the new template somehow?

MichaelCurrin commented 2 years ago

Sure.

Here is it rendered after I copied unaltered from markdown raw code on the branch


Fixes #.

Make sure all boxes are checked (add x inside the brackets) when you submit your contribution, remove this sentence before doing so.

To be completed below: Description of and rationale behind this PR.

MichaelCurrin commented 2 years ago

Alternatively you can preview it on the branch https://github.com/MichaelCurrin/nodemcu-firmware/blob/patch-3/.github/PULL_REQUEST_TEMPLATE.md