search

nodemcu / nodemcu-firmware

Lua based interactive firmware for ESP8266, ESP8285 and ESP32
https://nodemcu.readthedocs.io
MIT License
7.64k stars 3.12k forks source link

Update RTD MkDocs #3457

Closed marcelstoer closed 3 years ago

marcelstoer commented 3 years ago

Fixes #3454 for the IDF4 branch.

This will have to be carried over to the dev branch afterwards (to eventually end up on release as well). IMO we should skip doing this for dev-esp32 as it'll eventually be replaced by the IDF4 branch.

@jmattsson if https://nodemcu.readthedocs.io/en/update-rtd-mkdocs/ looks fine to you then this should be good enough to land.

jmattsson commented 3 years ago

Looks good to me from where I'm sitting!

jmattsson commented 3 years ago

Should I delete the update-rtd-mkdocs branch, or do you want it around a while longer @marcelstoer ?

marcelstoer commented 3 years ago

Thanks for asking, I removed it. I updated the RTD settings so we now have https://nodemcu.readthedocs.io/en/dev-esp32-idf4/.

jmattsson commented 3 years ago

Thanks Marcel!