Next release drop - Githubissues

nodemcu / nodemcu-firmware

Lua based interactive firmware for ESP8266, ESP8285 and ESP32

https://nodemcu.readthedocs.io

MIT License

7.64k stars 3.12k forks source link

Next release drop #3479

Closed marcelstoer closed 2 years ago

marcelstoer commented 2 years ago

Long overdue...

https://github.com/nodemcu/nodemcu-firmware/milestone/19?closed=1

nwf commented 2 years ago

Long overdue, no objections heard (and none from here)... here goes!

marcelstoer commented 2 years ago

Thanks! A question if I may, how did you manage to merge this one? You're listed as committer of all these changes and release/dev now diverged?

nwf commented 2 years ago

&#*^(&$@$. I just hit the rebase-and-merge button. Dammit, GitHub. I'm going to commit some violence (force push) to move release to 0b9785585e41003d29a3971758286b5a9d0df688 instead of its current location. I don't imagine this will actually cause problems because we probably haven't had many checkouts in the past 18 hours. I'm sorry I didn't notice sooner.

marcelstoer commented 2 years ago

Thanks. I now also merged my MkDocs bump into release so that the dependabot warning would go away.

marcelstoer commented 2 years ago

Oh and thanks for the release notes! I deleted the draft release (pointing to the same tag) that @HHHartmann's nice workflow created automatically. Not sure if you didn't see it or had different reasons for creating a separate one.

marcelstoer commented 2 years ago

Not sure if you didn't see it or

Maybe because our guidelines don't know about the auto-release yet 😄

nwf commented 2 years ago

Oh, I didn't see it. :(

HHHartmann commented 2 years ago

Too bad, that also removed the windows luac.cross binary which was attached to it.

nwf commented 2 years ago

Well nuts. Can it be rescued?

marcelstoer commented 2 years ago

that also removed the windows luac.cross binary which was attached to it

Sorry about that. Looks like I am also not up-to-date wrt our release process anymore.

Can it be rescued?

Yep

I re-ran the release pipeline from https://github.com/nodemcu/nodemcu-firmware/actions/runs/1638510368 ("Re-run all jobs" to right)
It re-created that draft release
I downloaded the luac.cross asset from it
Then uploaded it to the real release
And deleted the draft again

HHHartmann commented 2 years ago

That's wonderful. As far as I can see the one from the last release would have worked too but it's much better this way