Added mkdir/rmdir support to file module.

nodemcu / nodemcu-firmware

Lua based interactive firmware for ESP8266, ESP8285 and ESP32

https://nodemcu.readthedocs.io

MIT License

7.64k stars 3.12k forks source link

Added mkdir/rmdir support to file module. #3488

Closed jmattsson closed 1 year ago

jmattsson commented 2 years ago

[x] This PR is for the dev branch rather than for the release branch.
[x] This PR is compliant with the other contributing guidelines as well (if not, please describe why).
[x] I have thoroughly tested my contribution.
[x] The code changes are reflected in the documentation at docs/*.

When working with SD cards formatting with FAT, having the ability to create and remove directories become important. This PR exposes the IDF's mkdir and rmdir functions via the file module, since there is no standard Lua interface for it.

jmattsson commented 1 year ago

Somehow a year has already passed. @marcelstoer I'm going to both merge this and do the discussed branch renaming now; I've dawdled long enough, and I'm going to feel silly working on IDF5 support on a branch named IDF4 :D Also CC @pjsg a heads-up. I think we're the only active members on ESP32 at the moment?

marcelstoer commented 1 year ago

Thanks Johny. Can you also close the "migrate to IDF 4" tickets. IIRC there must be more than one.

I am really out of touch with the development here. Hence, I might need some help with https://github.com/marcelstoer/docker-nodemcu-build/issues/101 and https://github.com/marcelstoer/nodemcu-custom-build/issues/41. Probably won't take long until the support emails start coming in now 😄

jmattsson commented 1 year ago

I don't see any such tickets here. Do you have a link?

marcelstoer commented 1 year ago

Looks like #3397 is the only one out of those labeled with "ESP32": https://github.com/nodemcu/nodemcu-firmware/issues?q=is%3Aopen+is%3Aissue+label%3AESP32