Closed pjsg closed 2 years ago
requested a review from marcelstoer
Sorry Philip, I wish I did understand that code. I guess @jmattsson should take a look instead.
Other than the documentation issue Marcel picked up on, this looks good as far as I can see. Feel free to merge once that command->cmd has been adressed!
Fixes #3494.
dev
branch rather than for therelease
branch.docs/*
.There were a number of things broken about the
spi
support.transfer
for the address was actuallyaddr
rather thanaddress
cs
line has to be configured as a gpio and set to the inactive valuetxdata
argument totransfer
didn't work.This PR fixes all of the above and it appears to work (at least it drives the one device that I have tried it on!)