nodemcu / nodemcu-firmware

Lua based interactive firmware for ESP8266, ESP8285 and ESP32
https://nodemcu.readthedocs.io
MIT License
7.64k stars 3.12k forks source link

configure ledc to auto select clock #3503

Closed FelixPe closed 1 year ago

FelixPe commented 2 years ago

To be completed below: Description of and rationale behind this PR.

Added clock configuration according to https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/peripherals/ledc.html#_CPPv414ledc_clk_cfg_t

Fixes #3558

pjsg commented 2 years ago

Can you also add an invert option to this module that sets the output_invert flag in the ledc_channel_config_t? https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-reference/peripherals/ledc.html#_CPPv4N21ledc_channel_config_t13output_invertE

Thanks

jmattsson commented 1 year ago

I'm so sorry, I completely missed this PR. While Philip's request is good, I'm going to merge this fix right away as it's already way way overdue.