search

nodemcu / nodemcu-firmware

Lua based interactive firmware for ESP8266, ESP8285 and ESP32
https://nodemcu.readthedocs.io
MIT License
7.68k stars 3.13k forks source link

Next release snap #3635

Closed marcelstoer closed 9 months ago

marcelstoer commented 9 months ago

This was triggered by Gregor's comment at https://github.com/nodemcu/nodemcu-firmware/pull/3633#issuecomment-1930439746.

It's been ages since we last snapped something back to the release branch. What we documented at https://github.com/nodemcu/nodemcu-firmware/blob/release/CONTRIBUTING.md#handling-releases is mostly still correct 😄

HHHartmann commented 9 months ago

Would like to add 1 or 2 pull reques first.

marcelstoer commented 9 months ago

@HHHartmann which ones did you have in mind?

HHHartmann commented 9 months ago

I would suggest these at least:

and maybe this one, but it would need a little bit of love first

And of course I'd still like to get this integrated:

marcelstoer commented 9 months ago

The first four seemed like no-brainers. Hence, I felt confident to merge them 😄

As for the last one, I'm completely lost, not my world.

HHHartmann commented 9 months ago

When merging this PR a github workflow should start creating the release note together with attached luac.cross binaries for windows. So give it some time. Trigger is:

on:
  push:
    tags:
      - '3.*-release_*'
HHHartmann commented 9 months ago

found some more changes that hepled me: