nodenv / node-build-update-defs

Scrape build definitions from nodejs.org and github.com
MIT License
36 stars 7 forks source link

Learn to run the LTS message linter #56

Closed jasonkarns closed 4 years ago

jasonkarns commented 4 years ago

Inherits the LTS lint script from node-build. Tweaks script to be less noisy and avoid the sed/gsed incompatibility w.r.t. -i options.

Complication is the CWD of the script. Normally expected to be run from the root of node-build (thus share/node-build/ is relative). However, it's now expected to be run via npm explore -- npm run .... Thus the CWD is now this package's directory within node_modules. The other scripts here are temporarily using a hack to cd to git-repo root. But this only works as long as this package isn't installed as a git dep or npm-linked. (In both cases, this package itself is a git-repo-root, so that hack doesn't work.) To avoid the issue entirely, this script now expects the definition directory to be passed explicitly. It still has a default but that would likely fail most invocations.