search

nodenv / node-build

Install NodeJS versions
MIT License
271 stars 80 forks source link

Fix installation of prefix-retry.bash #721

Open mfdj opened 2 years ago

mfdj commented 2 years ago

In #479 I attempted to include prefix-retry.bash in the installation process. Turns out install -d didn't recursively copy as I'd hoped.

Had a spare moment so decided to tackle this again. Testing locally seems to get the right result!

mfdj commented 2 years ago

cc. @jasonkarns

mfdj commented 2 years ago

cc. @eregon

mfdj commented 2 years ago

So the goal is here to include the prefix-retry hook on installation, which is especially useful for folks who install this via a package manager like Homebrew, and don't have the source code on hand

In my org a lot of repos prioritize nvm + avn with secondary support for nodenv, so there will be .nvmrc with a symlinked .node-version file

I'm an advocate that engineers switch to nodenv because it's much simpler and more reliable, and the biggest hurdle is the nodenv install command. Since nvm requires a leading v in the version and node-build requires the opposite this small points adds enough friction that this plugin would be really high value

cc. @jasonkarns