search

nodertc / stun

Low-level Session Traversal Utilities for NAT (STUN) client and server
MIT License
160 stars 29 forks source link

Major package Update #33

Closed theimo1221 closed 2 years ago

theimo1221 commented 3 years ago

Following some npm audits, it might be a good idea to update some of stuns packages.

I made sure all my changes resulted in valid unit test completion.

theimo1221 commented 3 years ago

@olleolleolle Could you take a look over this?

theimo1221 commented 3 years ago

@olleolleolle Thanks for the quick review! Following your suggestion I updated the PR.

olleolleolle commented 3 years ago

(looks good to me!)

theimo1221 commented 3 years ago

(looks good to me!)

I thought you might have the necessary permissions to menge this PR and run a release...

Do you know how to reach one of the owners?

theimo1221 commented 3 years ago

@reklatsmasters Could you look into this please

reklatsmasters commented 2 years ago

A very controversial change, only brackets and bytes. Rejected.

theimo1221 commented 2 years ago

Hello @reklatsmasters,

I'm sorry but this PR doesn't just include brackets and bytes. The main purpose are those package updates and afterwards the correctness in regards to the defined linting rules.

@olleolleolle am I missing something here?