search

nodeschool / admin

CLI tool for setting up and maintaining a nodeschool chapters and other things.
17 stars 7 forks source link

Add Travis setup steps #14

Closed martinheidegger closed 8 years ago

martinheidegger commented 8 years ago

Right now running init and creating a chapter.json ends with the repo being pushed in a clean state. But travis is not yet set up to actually lint the chapter. It would be incredibly awesome if that could work automatically as well but if not: at least a good message for the user on how to do that would be good.

dinodsaurus commented 8 years ago

could you be a bit more specific about this one @martinheidegger ?

martinheidegger commented 8 years ago

The chapters should have a travis-script up & running that validates the state of the repository. (Reducing user errors).

Right now nodeschool-admin init creates a .travis.yml that will lint the repository every time a push happens. However, after init is finished travis is not being setup to actually setup to trigger when something in the repository changes.

There are several options how to deal with it.

  1. We could ask travis to support "trigger on all repositories in organization"
  2. We could search for a system that automatically triggers builds on all repos with .yml
  3. We could implement a on('push', checkIfContainsTravisYml(enableTravis)) in a own server like "github-teams" or through nodeschoolbot
  4. We could add a documentation stating that travis needs to be setup to verify.
dinodsaurus commented 8 years ago

I would go for the 4. solution, its easiest and it also promotes use of CI services, which is awesome I would say(we need more of that in the js community)

martinheidegger commented 8 years ago

I am okay with 4

RichardLitt commented 8 years ago

Agreed on 4.

dinodsaurus commented 8 years ago

Ok, now how can we check that their travis test passed ?

martinheidegger commented 8 years ago

@dinodsaurus We don't need to check that. The travis setup would be solely for the convenience of the chapter maintainer (to make less mistakes)