search

nodeschool / admin

CLI tool for setting up and maintaining a nodeschool chapters and other things.
17 stars 7 forks source link

Add Region to the list output #15

Closed martinheidegger closed 8 years ago

martinheidegger commented 8 years ago

Right now the list method only returns a array of chapters but since the chapter-designation.js file exists it would be good if the area was automatically added to each item in the list.

A PR that fills the json resulting from list with an area lookup would be mighty welcome.

dinodsaurus commented 8 years ago

hmmm could you give an example ?

martinheidegger commented 8 years ago

The current chapter.json contains region for reference link Part of my proposal is to move the place of the regions to one central logic. The chapter 'spec' already doesn't include the region anymore. But that the output of list should contain the region (compiled by the central logic): 

{
  "osaka": { 
    "region": "Asia", // <--- here
    "location": {
      "name": "Osaka",
      "country": "JP",
      "lat": 34.6937378,
      "lng": 135.5021651
    },
    "twitter": "nodeschoolosa",
    "name": "Osaka",
    "events": {}
  },
}
martinheidegger commented 8 years ago

PR #31 exists, closing this issue