GH Variables into a .config file

nodeschool / admin

CLI tool for setting up and maintaining a nodeschool chapters and other things.

17 stars 7 forks source link

Open fforres opened 8 years ago

fforres commented 8 years ago

What if we add a fallback for the Github variables gh-token, gh-client-id, gh-client-secret into a .config file that you could fill?

i.e. @ groupon we have those env. variables already set into our computers, but for Groupon's Enterprise Github.

martinheidegger commented 8 years ago

PR welcome :smile: :+1:

fforres commented 8 years ago

Will do :)

fforres commented 8 years ago

dinodsaurus commented 8 years ago

I think we can close this one because we wont need github variables. What do you think @martinheidegger

martinheidegger commented 8 years ago

For the moment this PR has become obsolete but we might need it in future versions if we add advanced features to the tool