search

nodeschool / admin

CLI tool for setting up and maintaining a nodeschool chapters and other things.
17 stars 7 forks source link

Feature/GitHub speed up #41

Closed martinheidegger closed 8 years ago

martinheidegger commented 8 years ago

The changes in the github lookup system of #39 removed the need for having github credentials to get the list of chapters. This pull request removes all traces of the github api calls. Also the requests were changed from serial to parallel. As result the list method should have gotten a pretty strong speed up.

@dinodsaurus You made changes here before, i would be honored if you could take a look at it.

dinodsaurus commented 8 years ago

Awesome PR!!!!! I refactored only some minor stuff :+1:

martinheidegger commented 8 years ago

LGTM

martinheidegger commented 8 years ago

Now looks fine

dinodsaurus commented 8 years ago

closes #20