nodeschool / costarica

:volcano: NodeSchool Costa Rica
http://nodeschool.io/costarica
5 stars 8 forks source link

github close keyword doesn't work #18

Open gaboesquivel opened 8 years ago

gaboesquivel commented 8 years ago

hey @a0viedo can you please help me finding out why github's close keywords don't work when I use them in nodeschool/costarica

gaboesquivel commented 8 years ago

Eg. pull requests #16 and #17 should have been closed in commits https://github.com/nodeschool/costarica/commit/6c8b25106456b3e33d929153aef13c91be2f2e81 and https://github.com/nodeschool/costarica/commit/d1988b142d46aa81b2fd85c8d1aa10f474ca3e37

gaboesquivel commented 8 years ago

none of the commit keywords work

fixes #xxx
resolve #xxx
close #xxx

@martinheidegger I think this is also related to permissions, do you know how to fix it? Enable commit keywords