search

nodeschool / montreal

🍁🗻 Montreal NodeSchool chapter
https://nodeschool.io/montreal/
25 stars 19 forks source link

[mentor]: add conan #113

Closed aconanlai closed 6 years ago

matchai commented 6 years ago

Hey Conan. Thank you for volunteering to join as a mentor! 👊 Could you please add your name to README.md and add your picture to the images directory?

You can check out this earlier PR as an example: https://github.com/nodeschool/montreal/pull/105

Cheers! 👍

aconanlai commented 6 years ago

done!

matchai commented 6 years ago

Thank you for the update! It looks like your addition to _config.yml is now missing, if you don't mind putting it back. 😅

ajmas commented 6 years ago

Image looks broken on main website. Was it named correctly?

matchai commented 6 years ago

Whoops! You're right. The name entered in _config.yml has to be the same as the image file name. All of this should definitely be better documented. 😅

I'll revert it for the time being. Feel free to open a new PR fixing the issue @aconanlai.

I'll just push a fix directly. Sorry for the trouble.