search

nodeschool / montreal

🍁🗻 Montreal NodeSchool chapter
https://nodeschool.io/montreal/
25 stars 19 forks source link

Add continuous integration to support i18n plugin #66

Closed ajmas closed 7 years ago

ajmas commented 7 years ago

Add continuous integration to support the i18n plugin, required to allow completing issue #1.

Proposal:

ajmas commented 7 years ago

Have created https://travis-ci.org/nodeschool/montreal , but still requires configuration. Can anyone who has commit access to this repo tell me if you are able to view the settings?

Also see https://jekyllrb.com/docs/continuous-integration/travis-ci/ for configuration guide.

matchai commented 7 years ago

Looks like it's all configured correctly by default! All we need is the travis.yml in the repo to get going.

Should I go ahead and make a PR with the travis.yml, or would you like to do the honors?

ajmas commented 7 years ago

I am looking at it now. Just doing a test build. Though if you have more time go for it. The one thing not resolved on my end is where to put the generated code.

matchai commented 7 years ago

I'll see if I've got time this evening to get around to it. As for the generated code, we would need it to be generated into the root of the project for gh-pages to see them, so we'll have to modify the jekyll config to have the source files in a "source" folder and the generated output in the root of the project.

matchai commented 7 years ago

Alternatively we can have a branch for the source files and the generated output deployed to gh-pages. (seems like the cleanest solution)

ajmas commented 7 years ago

If we can do a separate branch for generated content, then it would avoid mixing source and generated code? Also avoid the risk of recursive builds.

ajmas commented 7 years ago

This gist describes how to deploy to a github project: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd

ajmas commented 7 years ago

@matchai I am out of time for the next few days, but you can see in Travis the failure. If you have time could you look the failure with the openssl step? I think that is all that is missing.

ajmas commented 7 years ago

Reopening, since I just noticed we are limited to using gh-pages or master for gh-pages. It looks like I will need to reconfigure and change the source branch, I am thinking maybe something like gh-pages-src?