search

nodeschool / seattle

NodeSchool for Seattle!
http://nodeschool.io/seattle
42 stars 9 forks source link

Adding script to generate social image #55

Closed satanas closed 6 years ago

satanas commented 6 years ago

This PR fixes https://github.com/nodeschool/seattle/issues/54

JustinBeckwith commented 6 years ago

LGTM!

satanas commented 6 years ago

@Xabadu could you please take a look and merge if everything is ok? Thanks!

Xabadu commented 6 years ago

Hey @satanas, looks good to me. One question though, should this PR be against master?

satanas commented 6 years ago

@Xabadu that's a good question. I don't remember 😜. What base branch do you use for the PRs in SF?

Xabadu commented 6 years ago

master

satanas commented 6 years ago

@Xabadu done! Now master is the base branch